From 61cfb773e2649daf6e237ad828bacf62f1641e86 Mon Sep 17 00:00:00 2001
From: Deon George <deon@dege.au>
Date: Mon, 10 Jun 2024 09:19:21 +1000
Subject: [PATCH] Fix comments for Echomail Notifications

---
 app/Notifications/Channels/EchomailChannel.php | 5 ++---
 app/Notifications/Channels/NetmailChannel.php  | 3 +--
 app/Notifications/Echomails/AbsentNodes.php    | 4 +---
 app/Notifications/Echomails/Test.php           | 8 ++------
 4 files changed, 6 insertions(+), 14 deletions(-)

diff --git a/app/Notifications/Channels/EchomailChannel.php b/app/Notifications/Channels/EchomailChannel.php
index f3ee1a4..887cb61 100644
--- a/app/Notifications/Channels/EchomailChannel.php
+++ b/app/Notifications/Channels/EchomailChannel.php
@@ -6,11 +6,10 @@ use Illuminate\Notifications\Notification;
 use Illuminate\Support\Facades\Log;
 
 use App\Models\Echomail;
-use App\Models\Setup;
 
 class EchomailChannel
 {
-	private const LOGKEY = 'CN-';
+	private const LOGKEY = 'CNE';
 
 	/**
 	 * @var Echomail
@@ -18,7 +17,7 @@ class EchomailChannel
 	protected Echomail $echomail;
 
 	/**
-	 * Create a new Netmail channel instance.
+	 * Create a new Echomail channel instance.
 	 *
 	 * @param Echomail $o
 	 */
diff --git a/app/Notifications/Channels/NetmailChannel.php b/app/Notifications/Channels/NetmailChannel.php
index ec7bf97..e07dd9c 100644
--- a/app/Notifications/Channels/NetmailChannel.php
+++ b/app/Notifications/Channels/NetmailChannel.php
@@ -6,11 +6,10 @@ use Illuminate\Notifications\Notification;
 use Illuminate\Support\Facades\Log;
 
 use App\Models\Netmail;
-use App\Models\Setup;
 
 class NetmailChannel
 {
-	private const LOGKEY = 'CN-';
+	private const LOGKEY = 'CNN';
 
 	/**
 	 * @var Netmail
diff --git a/app/Notifications/Echomails/AbsentNodes.php b/app/Notifications/Echomails/AbsentNodes.php
index 05eeb12..0955774 100644
--- a/app/Notifications/Echomails/AbsentNodes.php
+++ b/app/Notifications/Echomails/AbsentNodes.php
@@ -20,9 +20,7 @@ class AbsentNodes extends Echomails
 	private Echomail $mo;
 
 	/**
-	 * Reply to a netmail ping request.
-	 *
-	 * @param Echomail $mo
+	 * Report on nodes that are have been marked Idle.
 	 */
 	public function __construct(private Collection $aos)
 	{
diff --git a/app/Notifications/Echomails/Test.php b/app/Notifications/Echomails/Test.php
index ee81826..fd19a42 100644
--- a/app/Notifications/Echomails/Test.php
+++ b/app/Notifications/Echomails/Test.php
@@ -17,18 +17,14 @@ class Test extends Echomails
 
 	private const LOGKEY = 'NNP';
 
-	private Echomail $mo;
-
 	/**
-	 * Reply to a netmail ping request.
+	 * Respond to a test in echomail.
 	 *
 	 * @param Echomail $mo
 	 */
-	public function __construct(Echomail $mo)
+	public function __construct(private Echomail $mo)
 	{
 		parent::__construct();
-
-		$this->mo = $mo;
 	}
 
 	/**