From 693e88bc015c8e22a51b9223d521f8a53bcef83a Mon Sep 17 00:00:00 2001 From: Deon George Date: Mon, 9 Sep 2024 14:20:55 +1000 Subject: [PATCH] Abort on M_SKIP since it incorreclty marks items as sent, and thus they are not sent again --- app/Classes/Protocol/Binkp.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/Classes/Protocol/Binkp.php b/app/Classes/Protocol/Binkp.php index e337627..c6fffec 100644 --- a/app/Classes/Protocol/Binkp.php +++ b/app/Classes/Protocol/Binkp.php @@ -1018,10 +1018,13 @@ final class Binkp extends BaseProtocol * @param string $buf * @return bool * @throws \Exception + * @todo We need to not add more files this session if a node skips a file + * @todo This incorrectly records the mail/file as sent and thus it is not sent again */ private function M_skip(string $buf): bool { - Log::info(sprintf('%s:+ Remote request to skip the file for now [%s]',self::LOGKEY,$buf)); + Log::debug(sprintf('%s:+ Remote request to skip the file for now [%s]',self::LOGKEY,$buf)); + throw new \Exception('We got a skip, but we dont handle it properly'); if ($file = $this->file_parse($buf)) { if ($this->send->nameas