bbs/clrghouz
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

Binkp control frames can be NULL terminated.

Browse Source
This commit is contained in:
Deon George 2023-11-24 13:13:38 +11:00
parent 9e870858da
commit bed5bf8acc
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/Classes/Protocol/Binkp.php
View File

@ -431,7 +431,8 @@ final class Binkp extends BaseProtocol
$rc = TRUE; $rc = TRUE;
} else { } else {
$data = substr($this->rx_buf,1); // http://ftsc.org/docs/fts-1026.001 - frames may be NULL terminated
$data = rtrim(substr($this->rx_buf,1),"\x00");
switch ($msg) { switch ($msg) {
case self::BPM_ADR: case self::BPM_ADR:
@ -1224,7 +1225,8 @@ final class Binkp extends BaseProtocol
} }
/** /**
* @throws \Exception * @todo It appears when we poll a node, we dont ask for passwords, but we still send echomail and files.
* @todo We should only send netmail if unauthenticated
*/ */
private function M_pwd(string $buf): bool private function M_pwd(string $buf): bool
{ {