From c8447d8573acbdb08ad2c727fc7eab7724b5594a Mon Sep 17 00:00:00 2001
From: Deon George <deon@leenooks.net>
Date: Sun, 4 Jul 2021 23:24:38 +1000
Subject: [PATCH] Update and display last seen for systems

---
 app/Classes/Node.php                  | 11 +++++++++--
 app/Classes/Protocol/Binkp.php        |  2 ++
 app/Models/System.php                 |  2 ++
 resources/views/domain/view.blade.php |  8 ++++----
 resources/views/system/ours.blade.php | 11 ++---------
 5 files changed, 19 insertions(+), 15 deletions(-)

diff --git a/app/Classes/Node.php b/app/Classes/Node.php
index be9669e..e8adaab 100644
--- a/app/Classes/Node.php
+++ b/app/Classes/Node.php
@@ -159,8 +159,11 @@ class Node
 			// If we have challenge, then we are doing MD5
 			$exp_pwd = $challenge ? $this->md5_challenge($o->session('sespass'),$challenge) : $o->session('sespass');
 
-			if ($exp_pwd === $password)
+			if ($exp_pwd === $password) {
+				$o->system->last_session = Carbon::now();
+				$o->system->save();
 				$this->ftns_authed->push($o);
+			}
 		}
 
 		Log::debug(sprintf('%s: = End [%d]',__METHOD__,$this->ftns_authed->count()));
@@ -227,7 +230,11 @@ class Node
 		$ftn = $this->ftns_authed->first()->ftn;
 
 		return $this->ftns->search(function($item) use ($ftn) {
-			return $item->ftn == $ftn;
+			if ($item->ftn == $ftn) {
+				$item->system->last_session = Carbon::now();
+				$item->system->save();
+				return TRUE;
+			}
 		}) !== FALSE;
 	}
 
diff --git a/app/Classes/Protocol/Binkp.php b/app/Classes/Protocol/Binkp.php
index ffcfc86..c6c7984 100644
--- a/app/Classes/Protocol/Binkp.php
+++ b/app/Classes/Protocol/Binkp.php
@@ -1027,6 +1027,8 @@ final class Binkp extends BaseProtocol
 	}
 
 	/**
+	 * Remote accepted our password
+	 *
 	 * @throws Exception
 	 */
 	private function M_ok(string $buf): int
diff --git a/app/Models/System.php b/app/Models/System.php
index a8b5b1d..8a3debf 100644
--- a/app/Models/System.php
+++ b/app/Models/System.php
@@ -12,6 +12,8 @@ class System extends Model
 {
 	use HasFactory,ScopeActive;
 
+	protected $dates = ['last_session'];
+
 	/* RELATIONS */
 
 	public function addresses()
diff --git a/resources/views/domain/view.blade.php b/resources/views/domain/view.blade.php
index 8fa90c7..1e53b11 100644
--- a/resources/views/domain/view.blade.php
+++ b/resources/views/domain/view.blade.php
@@ -74,7 +74,7 @@
 								<td>{{ $oz->system->sysop }}</td>
 								<td>{{ $oz->system->location }}</td>
 								<td>{{ $oz->zone_id }}:0/0</td>
-								<td>-</td>
+								<td>{{ $oz->system->last_session ? $oz->system->last_session->format('Y-m-d H:i') : '-' }}</td>
 							</tr>
 
 							@foreach ($oz->addresses()->active()->FTNorder()->where('point_id',0)->whereNull('hub_id')->with(['system','zone.domain'])->get() as $ao)
@@ -84,7 +84,7 @@
 										<td>{{ $ao->system->sysop }}</td>
 										<td>{{ $ao->system->location }}</td>
 										<td>{{ $oz->zone_id }}:{{ $ao->host_id }}/0</td>
-										<td>-</td>
+										<td>{{ $ao->system->last_session ? $ao->system->last_session->format('Y-m-d H:i') : '-' }}</td>
 									</tr>
 								@endif
 
@@ -93,7 +93,7 @@
 									<td>{{ $ao->system->sysop }}</td>
 									<td>{{ $ao->system->location }}</td>
 									<td>{{ $ao->ftn_3d }}</td>
-									<td>-</td>
+									<td>{{ $ao->system->last_session ? $ao->system->last_session->format('Y-m-d H:i') : '-' }}</td>
 								</tr>
 
 								<!-- If this node is a hub -->
@@ -104,7 +104,7 @@
 											<td>{{ $aoo->system->sysop }}</td>
 											<td>{{ $aoo->system->location }}</td>
 											<td>{{ $aoo->ftn_3d }}</td>
-											<td>-</td>
+											<td>{{ $aoo->system->last_session ? $aoo->system->last_session->format('Y-m-d H:i') : '-' }}</td>
 										</tr>
 									@endforeach
 								@endif
diff --git a/resources/views/system/ours.blade.php b/resources/views/system/ours.blade.php
index 371ea0d..b3bffb4 100644
--- a/resources/views/system/ours.blade.php
+++ b/resources/views/system/ours.blade.php
@@ -21,7 +21,7 @@
 						<th>System</th>
 						<th>Sysop</th>
 						<th>Location</th>
-						<th>Connect</th>
+						<th>Last Seen</th>
 						<th>Address</th>
 						<th>ZeroTier ID</th>
 					</tr>
@@ -35,14 +35,7 @@
 							<td>{{ $oo->system->name }}</td>
 							<td>{{ $oo->system->sysop }}</td>
 							<td>{{ $oo->system->location }}</td>
-							<td>
-								@switch($oo->system->method)
-									@case(23)<a href="telnet://{{ $oo->system->address }}:{{ $oo->system->port }}">Telnet</a>@break
-									@case(22)<a href="ssh://{{ $oo->system->address }}:{{ $oo->system->port }}">SSH</a>@break
-									@case(519)<a href="rlogin://{{ $oo->system->address }}:{{ $oo->system->port }}">SSH</a>@break
-									@default No details
-								@endswitch
-							</td>
+							<td>{{ $oo->system->last_session ? $oo->system->last_session->format('Y-m-d H:i') : '-' }}</td>
 							<td>{{ join(',',$oo->system->addresses->where('zone_id',$oo->zone_id)->pluck('ftn')->toArray()) }}</td>
 							<td>{{ $oo->system->zt_id }}</td>
 						</tr>