From 80ede4903f86bd27153cecb7eb2a01278fc62d1a Mon Sep 17 00:00:00 2001 From: Michiel Broek Date: Fri, 16 Dec 2005 20:12:17 +0000 Subject: [PATCH] If a file is not removed from disk during pack, a error log is created instead of a normal log --- ChangeLog | 2 ++ TODO | 12 ++++-------- mbfido/mbfpack.c | 4 ++-- 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/ChangeLog b/ChangeLog index ad4a3480..6780c018 100644 --- a/ChangeLog +++ b/ChangeLog @@ -6,6 +6,8 @@ v0.83.4 04-Dec-2005 Fixed file importing of non-archived files. The test for files.bbs for files to import was done in the wrong directory. + If a file is not removed from disk during pack, a error log + is created instead of a normal log. mbtask: Experimental code to recover from a half dead chatlink. diff --git a/TODO b/TODO index ca2e1b5d..45aa4ff2 100644 --- a/TODO +++ b/TODO @@ -30,10 +30,6 @@ install: L: On some (unsupported) distro's with xinetd the installation script also adds entries to inetd.conf. Is this still a problem? -libdiesel.a: - U: Processed stringlines containing unbalanced " characters are not - processed, instead the previous macro value will be returned. - mbsebbs: N: OLR, implement file requests. @@ -102,13 +98,13 @@ mbcico: mbnntp: U: fetched mail doesn't get the status Rcvd if it was for the user. - N: Do a better job for message linking by newsclients. + N: Do a better job for message linking by newsclients. This is a + problem because we use the message numbers and messages are + sometimes renumbered. This will make some clients try to fetch + the wrong messages because they cache the message id's. N: Lastread pointers are not updated. -mbfile: - N: Pack removes NODEDIFF.A87 but leaves the link nodediff.a87 - mbaff: L: Rewrite filefind search algorithm. diff --git a/mbfido/mbfpack.c b/mbfido/mbfpack.c index f26cfeea..066afb12 100644 --- a/mbfido/mbfpack.c +++ b/mbfido/mbfpack.c @@ -105,11 +105,11 @@ void PackFileBase(void) snprintf(fn, PATH_MAX, "%s/%s", area.Path, fdb.LName); rc = unlink(fn); if (rc && (errno != ENOENT)) - Syslog('+', "Unlink %s failed, result %d", fn, rc); + WriteError("PackFileBase(): unlink %s failed, result %s", fn, strerror(rc)); snprintf(fn, PATH_MAX, "%s/%s", area.Path, fdb.Name); rc = unlink(fn); if (rc && (errno != ENOENT)) - Syslog('+', "Unlink %s failed, result %d", fn, rc); + WriteError("PackFileBase(): unlink %s failed, result %s", fn, strerror(rc)); /* * If a dotted version (thumbnail) exists, remove it silently */