From c1980c359e6b6c3df6edb2c862fe7b5bb9a3bdaa Mon Sep 17 00:00:00 2001
From: Deon George <deon@leenooks.net>
Date: Sun, 24 Apr 2022 22:36:47 +1000
Subject: [PATCH] Fixed some sort() functions, added a groupby function

---
 frames_tag.js    |  4 ++--
 load/funcs.js    | 18 +++++++++++++-----
 load/msgbases.js |  2 +-
 3 files changed, 16 insertions(+), 8 deletions(-)

diff --git a/frames_tag.js b/frames_tag.js
index c60c1b2..68f49bc 100644
--- a/frames_tag.js
+++ b/frames_tag.js
@@ -5,7 +5,7 @@
 load('load/string.js');
 load('ansitex/load/msgbases.js');
 
-ma = new MsgAreas()
+const ma = new MsgAreas()
 for (var i=0;i<ma.areas.length;i++) {
 	writeln('Area: '+ma.areas[i].full_name);
 	writeln('Total Messages: '+ma.areas[i].list.length);
@@ -14,7 +14,7 @@ for (var i=0;i<ma.areas.length;i++) {
 	writeln('  '+ma.areas[i].list_tagged.map(function(x) { return x.tags; }).sort().join('|'));
 
 	writeln('Untagged Messages: '+ma.areas[i].list_untagged.length);
-	writeln('  '+ma.areas[i].list_untagged.map(function(x) { return x.number; }).sort().join('|'));
+	writeln('  '+ma.areas[i].list_untagged.map(function(x) { return x.number; }).sort(function(a,b) { return a-b; }).join('|'));
 
 	ma.areas[i].tag_msgs();
 }
diff --git a/load/funcs.js b/load/funcs.js
index 51120ca..9d4e93a 100644
--- a/load/funcs.js
+++ b/load/funcs.js
@@ -46,6 +46,18 @@ if (!String.prototype.repeat) {
 	};
 }
 
+// Group By
+if (!Array.prototype.groupby) {
+	Array.prototype.groupby = function(prop) {
+		return this.reduce(function(groups, item) {
+			const val = item[prop]
+			groups[val] = groups[val] || []
+			groups[val].push(item)
+			return groups
+		}, {})
+	};
+}
+
 /**
  * Convert ANSI into BIN for loading into a Frame
  *
@@ -70,10 +82,6 @@ function ans2bin(ansi,frame) {
 	}
 }
 
-function compare(a,b) {
-	return (a.prefix < b.prefix) ? 1 : ((b.prefix < a.prefix) ? -1 : 0);
-}
-
 /**
  * Find a message base by code
  *
@@ -162,7 +170,7 @@ function getPageOwners() {
 		f.close();
 
 		// Sort the pageowners ascending
-		pageowners.sort(compare);
+		pageowners.sort(function(a,b) { return (a.prefix < b.prefix) ? 1 : ((b.prefix < a.prefix) ? -1 : 0); });
 
 		//log(LOG_DEBUG,'+ pageOwner: pageowners='+JSON.stringify(pageowners));
 	}
diff --git a/load/msgbases.js b/load/msgbases.js
index e81eb3a..ad659c6 100644
--- a/load/msgbases.js
+++ b/load/msgbases.js
@@ -120,7 +120,7 @@ function MsgArea() {
 				}
 			}
 
-			return this.untagged_list.sort(function(x) { return x.when_written_time-(x.when_written_zone_offset*60); });
+			return this.untagged_list;
 		}
 	});