From aab2a5e12b1c7a5696b280528b4959b517649222 Mon Sep 17 00:00:00 2001
From: Stephen Paul Weber <singpolyma@singpolyma.net>
Date: Mon, 18 Feb 2013 18:39:24 -0500
Subject: [PATCH] Data representation bugs in signature subpackets

---
 lib/openpgp.php | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/openpgp.php b/lib/openpgp.php
index 927126c..5c090f4 100644
--- a/lib/openpgp.php
+++ b/lib/openpgp.php
@@ -946,7 +946,7 @@ class OpenPGP_SignaturePacket_SignatureExpirationTimePacket extends OpenPGP_Sign
 
 class OpenPGP_SignaturePacket_ExportableCertificationPacket extends OpenPGP_SignaturePacket_Subpacket {
   function read() {
-    $this->data = (ord($this->input) == 0);
+    $this->data = (ord($this->input) != 0);
   }
 
   function body() {
@@ -977,7 +977,7 @@ class OpenPGP_SignaturePacket_RegularExpressionPacket extends OpenPGP_SignatureP
 
 class OpenPGP_SignaturePacket_RevocablePacket extends OpenPGP_SignaturePacket_Subpacket {
   function read() {
-    $this->data = (ord($this->input) == 0);
+    $this->data = (ord($this->input) != 0);
   }
 
   function body() {
@@ -1066,7 +1066,7 @@ class OpenPGP_SignaturePacket_NotationDataPacket extends OpenPGP_SignaturePacket
     $flags = $this->read_bytes(4);
     $namelen = $this->read_unpacked(2, 'n');
     $datalen = $this->read_unpacked(2, 'n');
-    $this->human_readable = $flags[0] & 0x80 == 0x80;
+    $this->human_readable = ord($flags[0]) & 0x80 == 0x80;
     $this->name = $this->read_bytes($namelen);
     $this->data = $this->read_bytes($datalen);
   }
@@ -1137,7 +1137,7 @@ class OpenPGP_SignaturePacket_PreferredKeyServerPacket extends OpenPGP_Signature
 
 class OpenPGP_SignaturePacket_PrimaryUserIDPacket extends OpenPGP_SignaturePacket_Subpacket {
   function read() {
-    $this->data = (ord($this->input) == 0);
+    $this->data = (ord($this->input) != 0);
   }
 
   function body() {