deon
/
osb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Product class optimisation

This commit is contained in:
Deon George 2023-05-04 10:02:25 +10:00
parent a5238bfbdc
commit 0ac35c3d43
10 changed files with 31 additions and 85 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/Interfaces/ProductItem.php
View File

@ -6,10 +6,6 @@ use Illuminate\Support\Collection;
interface ProductItem
{
public function products();
public function supplied();
/**
* Return the traffic inclusion with the service
*

11
app/Models/Product.php
View File

@ -96,7 +96,9 @@ class Product extends Model implements IDs
public function translate()
{
return $this->hasOne(ProductTranslate::class)
->where('language_id',(Auth::user() && Auth::user()->language_id) ? Auth::user()->language_id : config('site')->language_id);
->where('language_id',(Auth::user() && Auth::user()->language_id)
? Auth::user()->language_id
: config('site')->language_id);
}
/**
@ -290,11 +292,12 @@ class Product extends Model implements IDs
/**
* Suppliers product
*
* @return Model|null
* @return Model
* @todo make internal as other values off this attribute are used, not the model itself
*/
public function getSuppliedAttribute(): ?Model
public function getSuppliedAttribute(): Model
{
return $this->type->supplied ? $this->type->supplied : NULL;
return $this->type->supplied;
}
/**

13
app/Models/Product/Broadband.php
View File

@ -34,17 +34,8 @@ final class Broadband extends Type implements ProductItem
// The model that is referenced when this product is ordered
protected string $order_model = ServiceBroadband::class;
/* RELATIONS */
/**
* The offering supplied with this product
*
* @return \Illuminate\Database\Eloquent\Relations\HasOne
*/
public function supplied()
{
return $this->hasOne(SupplierBroadband::class,'id','supplier_item_id');
}
// The model that the supplier supplies
const SupplierModel = SupplierBroadband::class;
/* INTERFACES */

13
app/Models/Product/Domain.php
View File

@ -31,17 +31,8 @@ final class Domain extends Type implements ProductItem
// The model that is referenced when this product is ordered
protected string $order_model = ServiceDomain::class;
/* RELATIONS */
/**
* The offering supplied with this product
*
* @return \Illuminate\Database\Eloquent\Relations\HasOne
*/
public function supplied()
{
return $this->hasOne(SupplierDomain::class,'id','supplier_item_id');
}
// The model that the supplier supplies
const SupplierModel = SupplierDomain::class;
/* INTERFACES */

13
app/Models/Product/Email.php
View File

@ -15,17 +15,8 @@ final class Email extends Type implements ProductItem
// The model that is referenced when this product is ordered
protected string $order_model = ServiceEmail::class;
/* RELATIONS */
/**
* The offering supplied with this product
*
* @return \Illuminate\Database\Eloquent\Relations\HasOne
*/
public function supplied()
{
return $this->hasOne(SupplierEmail::class,'id','supplier_item_id');
}
// The model that the supplier supplies
const SupplierModel = SupplierEmail::class;
/* INTERFACES */

13
app/Models/Product/Generic.php
View File

@ -15,17 +15,8 @@ final class Generic extends Type implements ProductItem
// The model that is referenced when this product is ordered
protected string $order_model = ServiceGeneric::class;
/* RELATIONS */
/**
* The offering supplied with this product
*
* @return \Illuminate\Database\Eloquent\Relations\HasOne
*/
public function supplied()
{
return $this->hasOne(SupplierGeneric::class,'id','supplier_item_id');
}
// The model that the supplier supplies
const SupplierModel = SupplierGeneric::class;
/* INTERFACES */

13
app/Models/Product/Host.php
View File

@ -15,17 +15,8 @@ final class Host extends Type implements ProductItem
// The model that is referenced when this product is ordered
protected string $order_model = ServiceHost::class;
/* RELATIONS */
/**
* The offering supplied with this product
*
* @return \Illuminate\Database\Eloquent\Relations\HasOne
*/
public function supplied()
{
return $this->hasOne(SupplierHost::class,'id','supplier_item_id');
}
// The model that the supplier supplies
const SupplierModel = SupplierHost::class;
/* INTERFACES */

13
app/Models/Product/Phone.php
View File

@ -42,17 +42,8 @@ final class Phone extends Type implements ProductItem
// The model that is referenced when this product is ordered
protected string $order_model = ServicePhone::class;
/* RELATIONS */
/**
* The offering supplied with this product
*
* @return \Illuminate\Database\Eloquent\Relations\HasOne
*/
public function supplied()
{
return $this->hasOne(SupplierPhone::class,'id','supplier_item_id');
}
// The model that the supplier supplies
const SupplierModel = SupplierPhone::class;
/* INTERFACES */

13
app/Models/Product/SSL.php
View File

@ -15,17 +15,8 @@ final class SSL extends Type implements ProductItem
// The model that is referenced when this product is ordered
protected string $order_model = ServiceSSL::class;
/* RELATIONS */
/**
* The offering supplied with this product
*
* @return \Illuminate\Database\Eloquent\Relations\HasOne
*/
public function supplied()
{
return $this->hasOne(SupplierSSL::class,'id','supplier_item_id');
}
// The model that the supplier supplies
const SupplierModel = SupplierSSL::class;
/* INTERFACES */

10
app/Models/Product/Type.php
View File

@ -27,6 +27,16 @@ abstract class Type extends Model
return $this->morphMany(Product::class, null,'model','model_id');
}
/**
* The offering supplied with this product
*
* @return \Illuminate\Database\Eloquent\Relations\HasOne
*/
public function supplied()
{
return $this->hasOne(static::SupplierModel,'id','supplier_item_id');
}
/**
* This will return the category of the product (eg: domain, hosting, etc) which is the basis for all
* other logic of these types.