Payments need to be active to be recognised

app/Http/Controllers/AdminController.php

@@ -116,6 +116,7 @@ class AdminController extends Controller
 			if (! $o->exists) {
 				$o->forceFill($request->only(['account_id','paid_at','checkout_id','checkout_id','total_amt','fees_amt','source_id','pending','notes','ip']));
 				$o->site_id = config('site')->site_id;
+				$o->active = TRUE;
 				$o->save();
 			}
 

app/Http/Controllers/PaypalController.php

@@ -200,6 +200,7 @@ class PaypalController extends Controller
 		foreach ($response->result->purchase_units as $pu) {
 			foreach ($pu->payments->captures as $cap) {
 				$po = new Payment;
+				$po->active = TRUE;
 
 				switch ($cap->status) {
 					case 'PENDING':

app/Jobs/PaymentsImport.php

@@ -88,6 +88,7 @@ final class PaymentsImport implements ShouldQueue
 
 					// New Payment
 					$po = new Payment;
+					$po->active = TRUE;
 					$po->site_id = 1; // @todo
 					$po->paid_at = $pd;
 					$po->checkout_id = '999'; // @todo

app/Models/Invoice.php

@@ -195,7 +195,8 @@ class Invoice extends Model implements IDs
 
 	public function payments()
 	{
-		return $this->hasManyThrough(Payment::class,PaymentItem::class,NULL,'id',NULL,'payment_id');
+		return $this->hasManyThrough(Payment::class,PaymentItem::class,NULL,'id',NULL,'payment_id')
+			->active();
 	}
 
 	public function paymentitems()
@@ -262,7 +263,7 @@ class Invoice extends Model implements IDs
 	public function getPaidAttribute(): float
 	{
 		return $this->paymentitems
-			->filter(function($item) { return ! $item->payment->pending_status; })
+			->filter(function($item) { return ! $item->payment->pending_status && $item->payment->active; })
 			->sum('amount');
 	}
 

app/Models/Payment.php

@@ -24,7 +24,7 @@ use App\Traits\PushNew;
  */
 class Payment extends Model implements IDs
 {
-	use PushNew;
+	use PushNew,ScopeActive;
 
 	protected $dates = [
 		'paid_at',

resources/views/theme/backend/adminlte/a/payment/unapplied.blade.php

@@ -32,7 +32,7 @@
 						</thead>
 
 						<tbody>
-						@foreach(\App\Models\Payment::unapplied()->with(['account.user','checkout','items'])->get() as $o)
+						@foreach(\App\Models\Payment::active()->unapplied()->with(['account.user','checkout','items'])->get() as $o)
 							@if (! $o->balance) @continue @endif
 							<tr>
 								<td><a href="{{ url('a/payment/addedit',$o->id) }}">{{ $o->id }}</td>

resources/views/theme/backend/adminlte/u/payment/widgets/list.blade.php

@@ -5,7 +5,7 @@
 	</div>
 
 	<div class="card-body">
-		@if(($x=$o->payments()->where('payments.created_at','>',\Carbon\Carbon::now()->subMonths(12)->unix())->with(['items','account'])->get())->count())
+		@if(($x=$o->payments()->active()->where('payments.created_at','>',\Carbon\Carbon::now()->subMonths(12)->unix())->with(['items','account'])->get())->count())
 			<table class="table table-bordered w-100" id="payments_past">
 				<thead>
 				<tr>