Abort on M_SKIP since it incorreclty marks items as sent, and thus they are not sent again
All checks were successful
Create Docker Image / Build Docker Image (x86_64) (push) Successful in 47s
Create Docker Image / Build Docker Image (arm64) (push) Successful in 1m50s
Create Docker Image / Final Docker Image Manifest (push) Successful in 10s

This commit is contained in:
Deon George 2024-09-09 14:20:55 +10:00
parent 2456402246
commit 693e88bc01

View File

@ -1018,10 +1018,13 @@ final class Binkp extends BaseProtocol
* @param string $buf * @param string $buf
* @return bool * @return bool
* @throws \Exception * @throws \Exception
* @todo We need to not add more files this session if a node skips a file
* @todo This incorrectly records the mail/file as sent and thus it is not sent again
*/ */
private function M_skip(string $buf): bool private function M_skip(string $buf): bool
{ {
Log::info(sprintf('%s:+ Remote request to skip the file for now [%s]',self::LOGKEY,$buf)); Log::debug(sprintf('%s:+ Remote request to skip the file for now [%s]',self::LOGKEY,$buf));
throw new \Exception('We got a skip, but we dont handle it properly');
if ($file = $this->file_parse($buf)) { if ($file = $this->file_parse($buf)) {
if ($this->send->nameas if ($this->send->nameas