deon/openpgp-php
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Data representation bugs in signature subpackets

Browse Source
This commit is contained in:
Stephen Paul Weber 2013-02-18 18:39:24 -05:00
parent 216ee4156d
commit aab2a5e12b
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/openpgp.php
View File

@ -946,7 +946,7 @@ class OpenPGP_SignaturePacket_SignatureExpirationTimePacket extends OpenPGP_Sign
class OpenPGP_SignaturePacket_ExportableCertificationPacket extends OpenPGP_SignaturePacket_Subpacket { class OpenPGP_SignaturePacket_ExportableCertificationPacket extends OpenPGP_SignaturePacket_Subpacket {
function read() { function read() {
$this->data = (ord($this->input) == 0); $this->data = (ord($this->input) != 0);
} }
function body() { function body() {
@ -977,7 +977,7 @@ class OpenPGP_SignaturePacket_RegularExpressionPacket extends OpenPGP_SignatureP
class OpenPGP_SignaturePacket_RevocablePacket extends OpenPGP_SignaturePacket_Subpacket { class OpenPGP_SignaturePacket_RevocablePacket extends OpenPGP_SignaturePacket_Subpacket {
function read() { function read() {
$this->data = (ord($this->input) == 0); $this->data = (ord($this->input) != 0);
} }
function body() { function body() {
@ -1066,7 +1066,7 @@ class OpenPGP_SignaturePacket_NotationDataPacket extends OpenPGP_SignaturePacket
$flags = $this->read_bytes(4); $flags = $this->read_bytes(4);
$namelen = $this->read_unpacked(2, 'n'); $namelen = $this->read_unpacked(2, 'n');
$datalen = $this->read_unpacked(2, 'n'); $datalen = $this->read_unpacked(2, 'n');
$this->human_readable = $flags[0] & 0x80 == 0x80; $this->human_readable = ord($flags[0]) & 0x80 == 0x80;
$this->name = $this->read_bytes($namelen); $this->name = $this->read_bytes($namelen);
$this->data = $this->read_bytes($datalen); $this->data = $this->read_bytes($datalen);
} }
@ -1137,7 +1137,7 @@ class OpenPGP_SignaturePacket_PreferredKeyServerPacket extends OpenPGP_Signature
class OpenPGP_SignaturePacket_PrimaryUserIDPacket extends OpenPGP_SignaturePacket_Subpacket { class OpenPGP_SignaturePacket_PrimaryUserIDPacket extends OpenPGP_SignaturePacket_Subpacket {
function read() { function read() {
$this->data = (ord($this->input) == 0); $this->data = (ord($this->input) != 0);
} }
function body() { function body() {